Conversation
…and consistent naming - Remove unused re-exports from registry.ts (serializeArg, serializeCommand, etc.) - Unify FormatOptions into SnapshotOptions from types.ts; rename dom-snapshot's SnapshotOptions to DomSnapshotOptions to avoid name collision - Extract shared analysis.ts module from explore.ts and record.ts, eliminating ~200 lines of duplicated logic (urlToPattern, findArrayPath, inferCapabilityName, inferStrategy, detectAuth*, classifyQueryParams) - Merge snapshotFormatter from 7-pass to 4-pass pipeline by combining parse+filter with ad/boilerplate subtree skipping, and merging three dedup passes into one - Rename all CLI adapter shared files to consistent utils.ts naming (boss/common.ts, douban/shared.ts, doubao*/common.ts, jike/shared.ts, medium/shared.ts, sinablog/shared.ts, substack/shared.ts) - Merge douban/shared.ts into douban/utils.ts
jackwener
force-pushed
the
claude/vigilant-ardinghelli
branch
from
b6d0fd7 to
541baa8
Compare
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry.ts—serializeArg,serializeCommandetc. were re-exported but never imported through this pathFormatOptionsin snapshotFormatter.ts was a subset ofSnapshotOptionsfrom types.ts; renamed dom-snapshot'sSnapshotOptionstoDomSnapshotOptionsto avoid collisionanalysis.tsfromexplore.tsandrecord.ts, eliminating ~200 lines of duplicated logic (urlToPattern,findArrayPath,inferCapabilityName,inferStrategy,detectAuth*,classifyQueryParams)shared.ts/common.tstoutils.tsacross 8 site adapters (boss, douban, doubao, doubao-app, jike, medium, sinablog, substack); merge douban'sshared.tsinto existingutils.tsNet effect: -54 lines, cleaner type hierarchy, less duplication, consistent naming.
Test plan
tsc --noEmitpassesnpm run buildsucceeds (328 manifest entries)