ci: add cross-platform CI matrix (Linux/macOS/Windows)#402
Merged
Conversation
…st, adapter-test Add OS matrix with ubuntu-latest, macos-latest, and windows-latest to the build, unit-test, and adapter-test CI jobs. This ensures cross- platform compatibility is verified on every push and PR. Smoke tests remain Linux-only due to xvfb dependency. Relates to #392 (Windows plugin path issues).
Fix Windows CI failures caused by hardcoded '/tmp' paths that don't exist on Windows. Use os.tmpdir() which returns the correct platform- specific temp directory on all operating systems. Files fixed: - src/engine.test.ts: 3 occurrences (mkdtemp, discoverClis path) - src/plugin.test.ts: 2 occurrences (getCommitHash test, mock condition)
- engine.test.ts: use pathToFileURL().href for dynamic import paths (path.join produces backslashes on Windows, breaking ES module imports) - download.test.ts: replace hardcoded '/tmp' with os.tmpdir() + path.join
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add OS matrix (
ubuntu-latest,macos-latest,windows-latest) to the build, unit-test, and adapter-test CI jobs. This ensures cross-platform compatibility is verified on every push and PR.Changes
xvfb)Motivation
All CI jobs previously ran exclusively on
ubuntu-latest, providing zero Windows/macOS test coverage. Issue #392 demonstrated that real Windows path bugs (URL.pathname, symlink permissions, esbuild resolution) went undetected until users reported them.Cost
Since opencli is a public repository, GitHub Actions minutes are free for all runner types.
Relates to #392