fix: pre-release cleanup — bugs, version sync, and error handling#412
Merged
fix: pre-release cleanup — bugs, version sync, and error handling#412
Conversation
Bug fixes: - Fix hasLimit using wrong Set (SEARCH_PARAMS → LIMIT_PARAMS) in analysis.ts classifyQueryParams - Remove phantom scroll step from BROWSER_STEPS and KNOWN_STEP_NAMES (declared but never registered, causes runtime crash if used in YAML) - Add missing download step to KNOWN_STEP_NAMES (was producing false-positive validation warnings) Docs: - Sync version numbers: SKILL.md, extension/package.json, extension/manifest.json → 1.3.3 - Add jd, web to README command tables (both EN and zh-CN) - Update xueqiu commands with fund-holdings, fund-snapshot Code quality: - Replace all 22 catch (err: any) with typed error handling using existing getErrorMessage() utility across 13 files
- antigravity/serve.ts: use typed Error.cause instead of (err as any).cause - external.ts: move instanceof guard into shouldRetryWithCmdShim, accept unknown instead of forcing NodeJS.ErrnoException cast at call site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release quality sweep addressing bugs, documentation gaps, and code hygiene.
Bug Fixes
analysis.ts:167—hasLimitwas checkingSEARCH_PARAMSinstead ofLIMIT_PARAMS, soclassifyQueryParams().hasLimitalways returned incorrect resultspipeline/executor.ts+validate.ts—scrollstep was declared inBROWSER_STEPSandKNOWN_STEP_NAMESbut never registered inregistry.ts. Using it in YAML would crash at runtime. Removed from declarations.validate.ts—downloadstep was missing fromKNOWN_STEP_NAMES, causing false-positive lint warnings on valid YAML pipelinesDocs
SKILL.md,extension/package.json,extension/manifest.json→1.3.3jd,webto README command tables (EN + zh-CN)xueqiuwith newfund-holdings,fund-snapshotcommandsCode Quality
catch (err: any)with typed error handling using existinggetErrorMessage()utility across 13 filesTest plan
tsc --noEmitpassesvitest run src/— 31 files, 328 tests all greencatch (err: any)in codebase