fix(weread): recover book details from cached shelf fallback#628
Merged
jackwener merged 1 commit intojackwener:mainfrom Mar 31, 2026
Merged
fix(weread): recover book details from cached shelf fallback#628jackwener merged 1 commit intojackwener:mainfrom
jackwener merged 1 commit intojackwener:mainfrom
Conversation
Owner
|
Merged after review. I specifically looked at the design intent here: make weread book detail resilient when the private API path is unavailable, while keeping fallback resolution conservative and safe. I validated with targeted Vitest, typecheck, and build before merge. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix WeRead
bookdetail fallback when private API auth has expired.This PR improves the detail fallback chain in two cases:
/web/shelfbefore search fallbackshelfIndexesnever hydrate but rendered shelf reader links still cover the cached entriesIt also adds regression tests for:
Related issue:
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output