fix: avoid in-page redirect in facebook search#642
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 31, 2026
Merged
Conversation
Replace `waitUntil: none` + separate `wait: 4` step with `settleMs: 4000` on the navigate step. This is consistent with other Facebook adapters (feed.yaml, memories.yaml, profile.yaml) and lets the navigate step handle the timing in one place.
jackwener
force-pushed
the
fix/facebook-search
branch
from
a034b9b to
9308985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
facebook/searchso it navigates to the search results page in the pipeline before extracting DOM data, instead of triggeringwindow.location.hrefinsideevaluate.Related issue: #625
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output
npx vitest run src/clis/facebook/search.test.ts --project adapternpm testpnpm exec tsc --noEmit && pnpm run build