forked from stan-dev/stan
-
Notifications
You must be signed in to change notification settings - Fork 0
Developer Process
Daniel Lee edited this page May 14, 2013
·
40 revisions
Rule 1. Branch master is in a releasable state.
Rule 2. All contributions come through pull requests.
-
Anyone can create a pull request.
-
A pull request should be unit-tested,
make test-unit, at the very least. If your code touches anything that goes into distributions, a pull request should test the distributions,make test-distributions. If your code touches the modeling language, you should run the model tests,make test-models. -
Anyone can do an informal code review for a pull request and leave comments on the pull request's page on GitHub.
-
One of the admins can start the tests on Jenkins (this may take hours).
-
One of the admins can declare code review done and push the patch to
master.
- We need to explain how things are labeled and milestoned in the issue tracker.
- Explain how to review a pull request.
- How to push the patch.