Skip to content
Daniel Lee edited this page May 14, 2013 · 40 revisions

Contributing Code

Rule 1. Branch master is in a releasable state.

Rule 2. All contributions come through pull requests.

  1. Anyone can create a pull request.

  2. A pull request should be unit-tested, make test-unit, at the very least. If your code touches anything that goes into distributions, a pull request should test the distributions, make test-distributions. If your code touches the modeling language, you should run the model tests, make test-models.

  3. Anyone can do an informal code review for a pull request and leave comments on the pull request's page on GitHub.

  4. One of the admins can start the tests on Jenkins (this may take hours).

  5. One of the admins can declare code review done and push the patch to master.

  • We need to explain how things are labeled and milestoned in the issue tracker.
  • Explain how to review a pull request.
  • How to push the patch.

Clone this wiki locally