Feature/add status to log #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@iq3addLi so sorry for the long delay, I hadn't noticed this come through. This looks great! Maybe since there is a dedicated attribute for status, we could remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi jagreenwood.
I've been trying out your nice library.
I wanted to add status to the attribute, so I did so. I've added a brief comment to the source.
Datadog was able to interpret most of the Log.Level definition in swift-log.
Level definitions in swift-log, but the trace has been bundled into a debug. I found that in the Datadog Doc.
So, I'm sorry for the simple PullRequest. Please check😁.