Skip to content

Skip empty records in map #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Skip empty records in map #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions notion/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ def call_load_page_chunk(self, page_id):

def store_recordmap(self, recordmap):
for table, records in recordmap.items():
if records is None: continue
Copy link
Contributor Author

@jheddings jheddings Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a field (__json__) in the user content that is occasionally set to None. This simply does a quick check and skips adding any empty record sets to the store.

Copy link

@AndreClaassen1 AndreClaassen1 Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. But still, I'm uneasy as to why this is occurring right now or this is the prelude to major API changes.

Copy link

@ttran ttran Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! This broke everything all at once for us 💯

Copy link
Contributor Author

@jheddings jheddings Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the change in this pull request or the bug?

Copy link

@ttran ttran Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the change in this pull request or the bug?

The bug! Thank you for the fix :)

Copy link
Contributor Author

@jheddings jheddings Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing... It was a quick change, just making sure it didn't have some other consequences 😄

Copy link

@ttran ttran Feb 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For folks wanting to monkey patch their code while waiting on the merge:

import notion
def store_recordmap(self, recordmap):
    for table, records in recordmap.items():
        if records is None: continue
        for id, record in records.items():
            self._update_record(
                table, id, value=record.get("value"), role=record.get("role")
            )
notion.store.RecordStore.store_recordmap = store_recordmap

Copy link

@phouse512 phouse512 Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to modify the first line in the above snippet to be import notion.store instead of import notion for it to work for me with python3.6 and notion==0.0.27.

thank you for the workaround until this gets merged!

for id, record in records.items():
self._update_record(
table, id, value=record.get("value"), role=record.get("role")
Expand Down