Use requests_mock instead of MagicMock to mock web requests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to add __repr__ to objects, we need to get the admin username in the __init__ method, which we can do by a call to /agents/ and then looking for the "owner" of the first agent. However, this seemingly minor change breaks the entire test infrastructure, because MagicMock can only be applied to a session AFTER it has been created, and if a web request is made in __init__ it cannot be mocked. We can solve this by using requests_mock to mock web requests!
Owner
Author
|
What an excellent idea. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
In order to add
__repr__toCallHub, we need to get the admin username in the__init__method, which we can do by a GET to /agents/ and then looking for the "owner" of the first agent. However, this seemingly minor change breaks the entire test infrastructure, because MagicMock can only be applied to a session AFTER it has been created, and if a web request is made in__init__it cannot be mocked.We can solve this by using requests_mock to mock web requests instead of MagicMock.