sign vs unsigned comparison issues. (Mozilla bugzilla issue 1633092)

[zephyrus00jp]

This is from mozilla bugzilla issue
https://bugzilla.mozilla.org/show_bug.cgi?id=1633092
TB build failure: GLSL optimizer output causes a compiler error (GCC-9) error: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compar

I am attaching the patch to fix the warning (= error under my local setting.) as text file.
(Well attachment is only allowed in certain types (detected by the suffices, I think, and .diff is not one of them.)

One is actually an unused variable in
src/compiler/glsl/ir_print_glsl_visitor.cpp: const bool is_lod
mozilla-bugzilla-1633092.txt

TIA

[zephyrus00jp]

This is from mozilla bugzilla issue
https://bugzilla.mozilla.org/show_bug.cgi?id=1633092
TB build failure: GLSL optimizer output causes a compiler error (GCC-9) error: comparison of integer expressions of different signedness: ‘long int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compar

I am attaching the patch to fix the warning (= error under my local setting.) as text file.
(Well attachment is only allowed in certain types (detected by the suffices, I think, and .diff is not one of them.)

One is actually an unused variable in
src/compiler/glsl/ir_print_glsl_visitor.cpp: const bool is_lod
mozilla-bugzilla-1633092.txt

TIA

Forgot to mention. It compiles cleanly.

 make
Scanning dependencies of target glcpp
[  1%] Building C object CMakeFiles/glcpp.dir/src/util/blob.c.o
[  2%] Building C object CMakeFiles/glcpp.dir/src/util/softfloat.c.o
[  3%] Building C object CMakeFiles/glcpp.dir/src/util/string_buffer.c.o
[  4%] Linking C static library libglcpp.a
[ 12%] Built target glcpp
[ 15%] Built target mesa
Scanning dependencies of target glsl_optimizer
[ 16%] Building CXX object CMakeFiles/glsl_optimizer.dir/src/compiler/glsl/ir_print_glsl_visitor.cpp.o
[ 16%] Building C object CMakeFiles/glsl_optimizer.dir/src/compiler/shader_enums.c.o
[ 17%] Linking CXX static library libglsl_optimizer.a
[ 98%] Built target glsl_optimizer
[ 99%] Linking CXX executable glslopt
[100%] Built target glslopt
ishikawa@ip030:/OLD-ROOT-DIR/repos/glsl-optimizer$ 

I have no idea how to test (and for that matter, test the change in the original mesa repository. Compilation is one thing, but testing is another.)

So far, I have used the patch in thunderbird mail client without ill-effect, but TB is not known for graphics acrobat.

TIA