Skip to content

Wrap all code that uses Tasks with async.Delay #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Wrap all code that uses Tasks with async.Delay #5

merged 1 commit into from
Oct 23, 2020

Conversation

@Herteby
Copy link
Contributor

@Herteby Herteby commented Oct 23, 2020

Wrap all code that uses Tasks with async.Delay, so that it behaves properly and doesn't execute until the Async computation is run.

Monads 🤩

Wrap all code that uses Tasks with async.Delay, so that it behaves pr…
65f417b 
…operly and doesn't execute until the Async computation is run.
jamil7
jamil7 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Owner

@jamil7 jamil7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Simon! 🤩

@jamil7 jamil7 merged commit 97a4277 into jamil7:main Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamil7 jamil7 jamil7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Herteby @jamil7