Skip to content

Adds sorting and filters to Headless CMS and Site Generator pages #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 3, 2020
Merged

Adds sorting and filters to Headless CMS and Site Generator pages #472

merged 9 commits into from
Dec 3, 2020

Conversation

@zachleat
Copy link
Member

@zachleat zachleat commented Dec 1, 2020 •
edited
Loading

@netlify
Copy link

netlify bot commented Dec 1, 2020 •
edited
Loading

✔️ Deploy preview for jamstack-site ready!

🔨 Explore the source changes: e58c23c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/jamstack-site/deploys/5fc7e90deb98720007e47ab7

😎 Browse the preview: https://deploy-preview-472--jamstack-site.netlify.app

@zachleat zachleat changed the title Adds filters to Headless CMS and Site Generator pages Adds sorting and filters to Headless CMS and Site Generator pages Dec 1, 2020
This was referenced Dec 1, 2020
Merged
Closed
@noraj
Copy link
Contributor

noraj commented Dec 2, 2020

This is a bit unrelated to those filters but you could want to keep this in mind.

On staticgen.org there were a bunch of linters, for example to check license names.

After netlify/staticgen#603 and netlify/staticgen#643, they implemented a CI task to check the license name of new committed tools are respecting the SPDX format.

You should maybe also create a whitelist of backend langue & template language so teh CI emit a warning when a new one is used this will avoid name drifting and having a list with python, Python, Python 3, python3, etc.

@zachleat
Copy link
Member Author

zachleat commented Dec 2, 2020

@noraj Excellent feedback! I wasn’t aware of that—I just added a console warning if there are invalid license names using spdx-checker. It doesn’t fail the build but it should help with drift.

Right now there are two invalid ones:

image

@zachleat zachleat marked this pull request as ready for review December 2, 2020 16:45
@zachleat
Copy link
Member Author

zachleat commented Dec 2, 2020

Alright this one is officially ready for a look 👍🏻

philhawksworth
philhawksworth approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@zachleat zachleat merged commit b7396ff into main Dec 3, 2020
@zachleat zachleat deleted the zl/filters branch December 3, 2020 20:12
mattstern31 pushed a commit to mattstern31/jamstack-plugin-dev that referenced this pull request Nov 10, 2022
Adds spdx license checker via feedback for jamstack/jamstack.org#472 …
7399358 
…(comment)
mattstern31 pushed a commit to mattstern31/awesome-jamstack that referenced this pull request Dec 1, 2022
Adds spdx license checker via feedback for jamstack/jamstack.org#472 …
d804621 
…(comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philhawksworth philhawksworth philhawksworth approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-add filters and sorting by programming lanuage on Site Generators and Headless CMS pages

4 participants

@zachleat @noraj @philhawksworth