Add Vibraphone icon to instruments. #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softins
approved these changes
Oct 25, 2021
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Looks fine to me. Builds on my Pi, and shows a nice icon.
pljones
approved these changes
Oct 25, 2021
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
(One of my common random asides: why is there no "Vocal Instrument" group?)
Member
Dunno - because history :) We could always add it. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add Vibraphone icon to instruments.
Changelog
added "Vibraphone" instrument icon, created by @vibraphon (#2043)
Context: Fixes an issue?
Yes. Finally an excellent Vibraphone/Marimba
Does this change need documentation? What needs to be documented and how?
No. However, Vibraphone should be translated into other languages as should a few other instruments.
Status of this Pull Request
Complete. Needs reviewers.
What is missing until this pull request can be merged?
An independent test would be good,
Checklist