Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 9, 2024

Describe Your Changes

According to discussion at #1088 , engine install and uninstall should be:

cortex engines install <engine>
cortex engines uninstall <engine>

Screenshots

Screenshot 2024-09-09 at 09 46 18

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

According to discussion, engine install and uninstall should be:

cortex engines install <engine>
cortex engines uninstall <engine>
@namchuai namchuai marked this pull request as ready for review September 9, 2024 03:05
@namchuai namchuai changed the title [#1088] Update engine install/uninstall CLI commands fix: update engine install/uninstall CLI commands Sep 9, 2024
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@namchuai namchuai merged commit e0ddb8d into dev Sep 9, 2024
@namchuai namchuai deleted the j/update-install-uninstall-engine branch September 9, 2024 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants