Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 11, 2024

Describe Your Changes

Support cortex models delete command
CLI syntax:

cortex models delete <model_id>

Server API:

DELETE http://127.0.0.1:3928/models/model_id

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 16, 2024 03:48
@namchuai
Copy link
Contributor

Would be great if we have some e2e tests 👯

@vansangpfiev
Copy link
Contributor Author

Would be great if we have some e2e tests 👯

Added e2e tests

Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 554bb84 into dev Sep 17, 2024
@vansangpfiev vansangpfiev deleted the feat/model-delete-cmd branch September 17, 2024 01:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: cortex models delete

3 participants