This repository was archived by the owner on Jul 4, 2025. It is now read-only.
feat: beta updater #1197
Merged
feat: beta updater #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
reviewed
Sep 12, 2024
dan-menlo
approved these changes
Sep 16, 2024
Contributor
dan-menlo
left a comment
dan-menlo
left a comment
There was a problem hiding this comment.
@vansangpfiev Approving to unblock.
Can I check my high-level understanding:
- We are breaking off beta updater from stable (previous)
- We are currently hard-coding Github URLs
Just FYI, we likely will support multiple download mirrors in the future, e.g. Github, Gitlab, Gitee
engine/commands/cortex_upd_cmd.cc
Outdated
| // Download file | ||
| constexpr auto github_host = "https://api.github.com"; | ||
| std::ostringstream release_path; | ||
| release_path << "/repos/janhq/cortex.cpp/releases"; |
Contributor
There was a problem hiding this comment.
@vansangpfiev Just a note, we may need to support multiple download sources in the future (e.g. Github, and mirrors in Gitlab, Gitee)
vansangpfiev
force-pushed
the
feat/beta-updater
branch
from
0cb1378 to
7b754ca
Compare
namchuai
reviewed
Sep 16, 2024
namchuai
reviewed
Sep 16, 2024
namchuai
approved these changes
Sep 16, 2024
Contributor
namchuai
left a comment
namchuai
left a comment
There was a problem hiding this comment.
✅ Great work! Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Support beta updater, for now we have:
Fixes Issues
Self Checklist