Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: spawn process linux #1210

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: spawn process linux #1210

merged 3 commits into from
Sep 13, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 13, 2024 •
edited
Loading

Describe Your Changes

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 13, 2024 08:22
namchuai
namchuai approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm. Let's test

@vansangpfiev
Copy link
Contributor Author

vansangpfiev commented Sep 13, 2024

Tested on Ubuntu, Mac-arm, Mac-intel

@vansangpfiev vansangpfiev merged commit f576d41 into dev Sep 13, 2024
@vansangpfiev vansangpfiev deleted the fix/spawn-process-linux branch September 13, 2024 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: [cortex-nightly] cortex.cpp unable to run in Mac arm

4 participants

@vansangpfiev @namchuai @nguyenhoangthuan99