feat: download model with direct url #1227
Conversation
namchuai
force-pushed
the
j/download-model-direct-url
branch
from
80fea5b to
3c6ffcc
Compare
namchuai
changed the title
namchuai
force-pushed
the
j/download-model-direct-url
branch
2 times, most recently
from
36de7e8 to
908f740
Compare
namchuai
force-pushed
the
j/download-model-direct-url
branch
from
908f740 to
897e3f6
Compare
Signed-off-by: James <namnh0122@gmail.com>
namchuai
force-pushed
the
j/download-model-direct-url
branch
from
897e3f6 to
8a3a590
Compare
namchuai
requested review from
dan-menlo,
louis-jan,
nguyenhoangthuan99 and
vansangpfiev
| CLI_LOG("Failed to uninstall engine " << engine_ << ": " << e.what()); | ||
| } | ||
| void EngineUninstallCmd::Exec(const std::string& engine) { | ||
| engine_service_.UninstallEngine(engine); |
There was a problem hiding this comment.
Should we return a boolean value for engine_service_.UninstallEngine? Seems like we always delete engine successfully.
There was a problem hiding this comment.
If the uninstallation is failed, it will be handled via exception here.
Signed-off-by: James <namnh0122@gmail.com>
namchuai
force-pushed
the
j/download-model-direct-url
branch
from
05e468e to
5d06c15
Compare
|
@namchuai Can we be a bit careful about using force-push? It blows away the files changes in Github, making it difficult to review additional diffs |
I see. I'm using force push to clean up the commit list before merged to dev branch, for keeping it clean. I'm not sure if this is enough but you can see that change via button Compare here. |
Describe Your Changes
Testing command
Can switch the url to your own url
build/cortex pull https://huggingface.co/BafS/gemma-2-2b-it-Q4_K_M-GGUF/blob/main/gemma-2-2b-it-q4_k_m.ggufScreenshot
Linked issue
Self Checklist