Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: print all logs to terminal with --verbose #1228

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: print all logs to terminal with --verbose #1228

merged 3 commits into from
Sep 17, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 16, 2024

Describe Your Changes

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 16, 2024 07:24
dan-menlo
dan-menlo approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vansangpfiev vansangpfiev merged commit d81c801 into dev Sep 17, 2024
@vansangpfiev vansangpfiev deleted the fix/verbose branch September 17, 2024 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@namchuai namchuai Awaiting requested review from namchuai

1 more reviewer

@dan-menlo dan-menlo dan-menlo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: cortex should output logs to terminal with --verbose

3 participants

@vansangpfiev @dan-menlo