Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 19, 2024

Describe Your Changes

  • Using Result instead of throwing exception. Throwing exception is expensive in C++.

TODOs

  • Add result support for ModelService
  • Add result support for EngineService

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai changed the title feat: replace result api instead of throwing exception chore: replace result api instead of throwing exception Sep 19, 2024
@namchuai namchuai force-pushed the j/replace-result-for-exception branch from 6284f16 to fda497a Compare September 24, 2024 09:29
@namchuai namchuai force-pushed the j/replace-result-for-exception branch from fda497a to 1db9cad Compare September 24, 2024 09:37
@namchuai namchuai marked this pull request as ready for review September 24, 2024 09:39
@namchuai namchuai force-pushed the j/replace-result-for-exception branch from 7293382 to fa045c8 Compare September 24, 2024 10:21
@namchuai namchuai merged commit 9707a3b into dev Sep 24, 2024
@namchuai namchuai deleted the j/replace-result-for-exception branch September 24, 2024 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants