Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: e2e failed test when download model with selection #1260

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: e2e failed test when download model with selection #1260

merged 1 commit into from
Sep 19, 2024

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 19, 2024

Describe Your Changes

  • Fix a test case that relied on downloading model first, but download model now print out selection for variant and a variant need to be chosen to be continued download.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai merged commit 22467b7 into dev Sep 19, 2024
@namchuai namchuai deleted the j/fix-e2e-failed-test branch September 19, 2024 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

1 more reviewer

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namchuai @nguyenhoangthuan99