Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@nguyenhoangthuan99
Copy link
Contributor

Implement list and get command

Fix #1075

Logic flow:

  • Read entries in model.list
  • Get information about model_id and path/to/model.yml
  • Read yaml file and return information

Model list example output

image

Model get example output

image

@nguyenhoangthuan99 nguyenhoangthuan99 marked this pull request as ready for review September 20, 2024 01:18
@namchuai
Copy link
Contributor

I think we should move the print logic of ModelConfig to its struct member function (ToString() for example) to reduce the code duplication between CLI and controller.

IMO, Model's logic stuffs should be placed in ModelService. In the future, we will need to centralize this ModelService so that we can easily get what model is running (for example). CLI and Http API should just serve as an interface to communicate.

@namchuai
Copy link
Contributor

✅ lgtm

@nguyenhoangthuan99 nguyenhoangthuan99 merged commit 7cf2797 into dev Sep 20, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 deleted the feat/model-get branch September 20, 2024 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: cortex models get <MODEL_ID> and cortex models list

4 participants