Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: set timeout for checking new update #1276

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: set timeout for checking new update #1276

merged 2 commits into from
Sep 20, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Sep 20, 2024 •
edited
Loading

Describe Your Changes

  • set timeout to 1 second

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review September 20, 2024 01:24
namchuai
namchuai approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 1c835d7 into dev Sep 20, 2024
@vansangpfiev vansangpfiev deleted the fix/check-update-timeout branch September 20, 2024 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hiento09 hiento09 Awaiting requested review from hiento09

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vansangpfiev @namchuai