Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@nguyenhoangthuan99
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 commented Oct 1, 2024

Fix #1322

Add swagger for api. After running server, go to http://127.0.0.1:3928/swagger to access swagger page.

image

@nguyenhoangthuan99 nguyenhoangthuan99 marked this pull request as ready for review October 1, 2024 01:28
@dan-menlo
Copy link
Contributor

For easier discoverability, it possible to put this at the root URL (localhost:3928) vs the /swagger route?

@nguyenhoangthuan99
Copy link
Contributor Author

nguyenhoangthuan99 commented Oct 1, 2024

yes, we can also access to swagger page through http://localhost:3928/swagger

@nguyenhoangthuan99 nguyenhoangthuan99 merged commit f86754e into dev Oct 2, 2024
4 checks passed
@nguyenhoangthuan99 nguyenhoangthuan99 deleted the feat/add-swagger branch October 2, 2024 01:13
@gabrielle-ong
Copy link
Contributor

@nguyenhoangthuan99

  1. I think Daniel is suggesting to use the root url http://127.0.0.1:3928 (or maybe /api?), as a user I may not know to go to /swagger
  2. Previous version of cortex.js CLI - cortex start outputed this link, so as a user I can easily click and open the link. Can we bring that back?

Currently:

> cortex start
Host: 127.0.0.1 Port: 3928
Server started

@nguyenhoangthuan99
Copy link
Contributor Author

nguyenhoangthuan99 commented Oct 3, 2024

I fixed in this pr #1392

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idea: Cortex API Playground

5 participants