Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: ignore SIGINT for server #1371

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: ignore SIGINT for server #1371

merged 3 commits into from
Oct 1, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 1, 2024 •
edited
Loading

Describe Your Changes

cortex chat is working on interactive mode. If we send a SIGINT, the server will be terminated.
We should ignore SIGINT for server.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title fix: ignore sigint server fix: ignore SIGINT for server Oct 1, 2024
@vansangpfiev vansangpfiev marked this pull request as ready for review October 1, 2024 03:33
@vansangpfiev vansangpfiev merged commit 5c2cae1 into dev Oct 1, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/ignore-sigint-server branch October 1, 2024 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vansangpfiev @namchuai @sangjanai