Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

Describe Your Changes

  • Use relative path for yaml file path and model files
  • In case of Import, we use relative path for yaml file and keep the model files as is

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 3, 2024 06:03
@vansangpfiev vansangpfiev changed the title fix: db rel path fix: use relative path for model information Oct 3, 2024
Copy link
Contributor

@dan-menlo dan-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm to unblock. Can you link corresponding issue/motivation?

@vansangpfiev
Copy link
Contributor Author

Lgtm to unblock. Can you link corresponding issue/motivation?

It is Louis's suggestion:
https://discordapp.com/channels/1107178041848909847/1204617960615055401/1290493569156776088

@vansangpfiev vansangpfiev merged commit 8657549 into dev Oct 3, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/db-rel-path branch October 3, 2024 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants