Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: no sudo for root use #1421

Merged
merged 10 commits into from
Oct 4, 2024
Merged

fix: no sudo for root use #1421

merged 10 commits into from
Oct 4, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 4, 2024 •
edited
Loading

Describe Your Changes

  • only ask user to run with sudo if not root
  • change return from std::vector to std::unordered_map for GetModelRepositoryBranches

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title fix: folder for root user fix: no sudo for root use Oct 4, 2024
namchuai
namchuai approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev marked this pull request as ready for review October 4, 2024 04:52
@vansangpfiev vansangpfiev merged commit f9a1a4d into dev Oct 4, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/folder-for-root branch October 4, 2024 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vansangpfiev @namchuai @nguyenhoangthuan99 @sangjanai