Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: chat completion parameters #1440

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: chat completion parameters #1440

merged 1 commit into from
Oct 7, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 7, 2024

Describe Your Changes

  • Send all chat completion parameters

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 7, 2024 02:35
@vansangpfiev vansangpfiev merged commit 4e691b1 into dev Oct 7, 2024
8 checks passed
@vansangpfiev vansangpfiev deleted the fix/chat branch October 7, 2024 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@namchuai namchuai namchuai approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vansangpfiev @namchuai @nguyenhoangthuan99