Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 15, 2024

Describe Your Changes

  • All commands are executed by requesting API server, except cortex pull and cortex engines install (will improve in another PR)
  • Separate CLI and Server into binaries will be in another PR also
  • Remove deprecated API endpoints for swagger

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev changed the title fix: separate CLI and APIs server fix: Cortex CLI should be a layer on top of the API Server Oct 16, 2024
@vansangpfiev vansangpfiev marked this pull request as ready for review October 16, 2024 05:05
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@vansangpfiev vansangpfiev merged commit 6f22aa1 into dev Oct 16, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/swagger branch October 16, 2024 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants