Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: crash when calling process kill api #1497

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: crash when calling process kill api #1497

merged 1 commit into from
Oct 16, 2024

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Oct 16, 2024

Describe Your Changes

  • Fix a crash when terminate server when calling processmanager/kill
  • Remove code which manually create DownloadService

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai
fix: crash when calling process kill api
3f70e09 
Also remove memory alloc for DownloadService, instead, injected.
@namchuai namchuai marked this pull request as ready for review October 16, 2024 05:09
@namchuai namchuai merged commit 2800e79 into dev Oct 16, 2024
8 checks passed
@namchuai namchuai deleted the j/fix-crash-issue branch October 16, 2024 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dan-menlo dan-menlo Awaiting requested review from dan-menlo

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

1 more reviewer

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namchuai @vansangpfiev