Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented Oct 21, 2024

Describe Your Changes

  • Allow user to specify their desired model_id.
  • Add a thread safe data structure for DownloadTaskQueue. Working on refactor DownloadService to use new DownloadTaskQueue to support parallel download.
  • Clean up alias API.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Preview URL: https://8dffaa6b.cortex-docs.pages.dev

@namchuai namchuai force-pushed the j/simplified-cortex-run branch 2 times, most recently from e2b58cf to 0aad82c Compare October 21, 2024 01:52
Base automatically changed from j/simplified-cortex-run to dev October 21, 2024 06:47
@namchuai namchuai force-pushed the j/update-download-api branch 2 times, most recently from 03667eb to 7403762 Compare October 21, 2024 07:26
@namchuai namchuai force-pushed the j/update-download-api branch from 7403762 to 082635e Compare October 21, 2024 07:29
@namchuai namchuai requested a review from vansangpfiev October 21, 2024 07:30
@namchuai namchuai changed the title J/update download api fix: update download api Oct 21, 2024
@namchuai namchuai force-pushed the j/update-download-api branch from 13e9a9b to 5050bc3 Compare October 21, 2024 09:19
@namchuai namchuai merged commit 5562284 into dev Oct 21, 2024
5 checks passed
@namchuai namchuai deleted the j/update-download-api branch October 21, 2024 09:36
@louis-jan
Copy link
Contributor

This change broke Jan's cortex because it blocks custom engine path support. @vansangpfiev @namchuai

@dan-menlo
Copy link
Contributor

dan-menlo commented Oct 22, 2024

This change broke Jan's cortex because it blocks custom engine path support. @vansangpfiev @namchuai

@louis-jan @vansangpfiev @namchuai Can I understand this a bit more in detail - what does it mean by blocking custom engine path support?

Does this mean we have to revert?

@louis-jan
Copy link
Contributor

louis-jan commented Oct 22, 2024

This change broke Jan's cortex because it blocks custom engine path support. @vansangpfiev @namchuai

@louis-jan @vansangpfiev @namchuai Can I understand this a bit more in detail - what does it mean by blocking custom engine path support?

Does this mean we have to revert?

Hey @dan-homebrew guys fixed it already. Applications embed Cortex, which bundles engines that aren't fixed at ~/cortex/engines since engines install won't be done in run-time. They could be mac-arm/engines, mac-intel/engines, or windows/engines or pre-packaged. And they can point to the corresponding engine at runtime via env or args.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants