Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: Isolate stdout from the API server and CLI #1526

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix: Isolate stdout from the API server and CLI #1526

merged 2 commits into from
Oct 22, 2024

Conversation

@vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Oct 21, 2024

Describe Your Changes

  • Only print service log if current executable is CLI
  • Use async for engine download API

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review October 21, 2024 09:07
@vansangpfiev vansangpfiev requested a review from namchuai October 21, 2024 09:07
@vansangpfiev vansangpfiev merged commit 3f9680c into dev Oct 22, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/isolate-log-server-cli branch October 22, 2024 01:31
@namchuai namchuai mentioned this pull request Oct 22, 2024
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vansangpfiev @namchuai @sangjanai