This repository was archived by the owner on Jul 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 181
feat: Hardware API #1593
Merged
Merged
feat: Hardware API #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview URL: https://2884bb8e.cortex-docs.pages.dev |
namchuai
reviewed
Nov 13, 2024
namchuai
reviewed
Nov 13, 2024
namchuai
reviewed
Nov 13, 2024
namchuai
reviewed
Nov 13, 2024
namchuai
reviewed
Nov 13, 2024
namchuai
approved these changes
Nov 13, 2024
Contributor
namchuai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Overall lgtm. Only some nits and should not be blocked. Great job!
e1cbadc to
d101182
Compare
d101182 to
5707dd7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
{ "cpu": { "arch": "amd64", "cores": 8, "instructions": [ "fpu", "mmx", "sse", "sse2", "sse3", "ssse3", "sse4_1", "sse4_2", "pclmulqdq", "avx", "avx2", "aes", "f16c" ], "model": "AMD Ryzen Threadripper PRO 5955WX 16-Cores" }, "gpus": [ { "additional_information": { "compute_cap": "8.6", "driver_version": "535.183" }, "free_vram": 24246, "name": "NVIDIA GeForce RTX 3090", "total_vram": 24576, "version": "12.2" } ], "os": { "name": "Ubuntu 24.04.1 LTS", "version": "24.04.1 LTS (Noble Numbat)" }, "power": { "battery_life": 0, "charging_status": "", "is_power_saving": false }, "ram": { "available": 14335725568, "total": 16768770048, "type": "" }, "storage": { "available": 0, "total": 0, "type": "" } }Fixes Issues
Self Checklist