This repository was archived by the owner on Jul 4, 2025. It is now read-only.
chore: add model name as a parameter support during import via API #1600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
modelor blank space. This chore update allow clients to decide the model name. Also provided the missing API doc schema.Changes made
In
models.cc:modelNameis extracted from the JSON request.modelHandleis empty.namefield ofmodel_configis updated withmodelNameif it's not empty.In
test_api_model_import.py:json = body_jsontojson=body_json).a. Testing model import with a custom name (marked to skip by default).
b. Testing model import with an invalid path (expected to fail).
c. Testing model import with a missing model (expected to fail).
A new endpoint
/v1/models/importis added:Two new schemas are added:
ImportModelRequest:ImportModelResponse:Pull with a desired name
These changes enhance the model import functionality by allowing custom names and adding more robust error checking. The new test cases improve the coverage of the API's behavior under different scenarios. Also provided the missing API doc, with appropriate request and response structures defined in the OpenAPI specification.
Self Checklist