Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Fix/gemma2 chat template #1657

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Fix/gemma2 chat template #1657

merged 5 commits into from
Nov 11, 2024

Conversation

@nguyenhoangthuan99
Copy link
Contributor

@nguyenhoangthuan99 nguyenhoangthuan99 commented Nov 8, 2024 •
edited
Loading

Describe Your Changes

  • Fix chat template renderer for gemma2 model

new chat template

<start_of_turn>user\n{system_message}<end_of_turn>\n<start_of_turn>user\n{prompt}<end_of_turn>\n<start_of_turn>model\n

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Preview URL: https://ce7e1e8f.cortex-docs.pages.dev

@nguyenhoangthuan99 nguyenhoangthuan99 marked this pull request as ready for review November 8, 2024 07:01
namchuai
namchuai reviewed Nov 8, 2024
View reviewed changes
namchuai
namchuai approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@nguyenhoangthuan99 nguyenhoangthuan99 merged commit 7cf62d5 into dev Nov 11, 2024
5 checks passed
@nguyenhoangthuan99 nguyenhoangthuan99 deleted the fix/gemma2-chat-template branch November 11, 2024 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

1 more reviewer

@namchuai namchuai namchuai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nguyenhoangthuan99 @namchuai