Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented May 23, 2024

Describe Your Changes

  • allow user to pull model from janhq from HuggingFace

Videos

Screen.Recording.2024-05-23.at.15.35.13.mov

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the feat/pull-model-yaml branch 3 times, most recently from fadceac to e4c36dd Compare May 23, 2024 08:07
@namchuai namchuai marked this pull request as ready for review May 23, 2024 08:37
@namchuai namchuai requested a review from louis-jan May 23, 2024 08:37
@namchuai namchuai force-pushed the feat/pull-model-yaml branch from e4c36dd to 707a24a Compare May 23, 2024 08:54
@louis-jan
Copy link
Contributor

How can I make it work?

Screenshot 2024-05-24 at 10 31 57

@namchuai namchuai force-pushed the feat/pull-model-yaml branch 4 times, most recently from 6151fea to d4b8a75 Compare May 25, 2024 15:47
@namchuai namchuai force-pushed the feat/pull-model-yaml branch from d4b8a75 to 3282153 Compare May 25, 2024 15:48
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit c588048 into dev May 27, 2024
@namchuai namchuai deleted the feat/pull-model-yaml branch May 27, 2024 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants