Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Conversation

@namchuai
Copy link
Contributor

@namchuai namchuai commented May 27, 2024

Describe Your Changes

  • Store cortex data in a separate directory so user can freely upgrade their cortex without worry losing their data.
  • Store cortex setting under ~/.cortexrc. Consider removing suffix rc because it seems abit weird.

Screenshots

Screenshot 2024-05-27 at 17 02 03

Screenshot 2024-05-27 at 17 05 55

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-jan May 27, 2024 10:05
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 5603112 into dev May 28, 2024
@namchuai namchuai deleted the feat/add-cortex-data-folder branch May 28, 2024 08:17
@Van-QA
Copy link
Contributor

Van-QA commented May 31, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants