Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

fix: cortex serve should run in attached mode by default #711

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: cortex serve should run in attached mode by default #711

merged 1 commit into from
Jun 17, 2024

Conversation

@louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jun 17, 2024

Describe Your Changes

  • As a user, when I run cortex serve, I would like to see it run in attached mode, allowing me to observe the incoming requests

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan merged commit b77fb70 into dev Jun 17, 2024
@louis-jan louis-jan deleted the fix/serve-attached-mode-default branch June 17, 2024 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@namchuai namchuai Awaiting requested review from namchuai

1 more reviewer

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@louis-jan @marknguyen1302