Prep double for jank
#790
Open
Prep double for jank
#790
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
requested changes
Nov 7, 2025
| ;; In cljs, `double` is just returns the argument unchanged (dummy fn) | ||
| [(is (= "0" (double "0"))) | ||
| (is (= :0 (double :0)))] | ||
| :jank [] |
Member
There was a problem hiding this comment.
What does jank do for these two cases? We can't just not test these two cases with jank.
Contributor
Author
|
Keeping this PR till the blocking issue is resolved. |
shantanu-sardesai
force-pushed
the
issues/415-double-port
branch
from
7e2a22b to
a702d7e
Compare
shantanu-sardesai
added a commit
to shantanu-sardesai/jank
that referenced
this pull request
Nov 18, 2025
jeaye
pushed a commit
to jank-lang/jank
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created for the port in
jank.