Skip to content

fix: update nix vendorHash for go modules#343

Merged
janosmiko merged 1 commit into
mainfrom
fix/nix-vendor-hash-341
Jun 2, 2026
Merged

fix: update nix vendorHash for go modules#343
janosmiko merged 1 commit into
mainfrom
fix/nix-vendor-hash-341

Conversation

@janosmiko
Copy link
Copy Markdown
Owner

@janosmiko janosmiko commented Jun 2, 2026

Summary

  • Updates the stale vendorHash in flake.nix to the current go modules hash for 0.13.3, fixing the hash mismatch on nix run github:janosmiko/lfk.

The new hash (sha256-i19f+Kqeh5kW5w8HKhD/ppboYzNBRIOb37pzWZhOAN4=) matches the got: value reported in the bug.

Fixes #341

Test plan

  • nix run github:janosmiko/lfk builds and launches without a hash mismatch

The flake's vendorHash was stale for 0.13.3, causing a hash mismatch on
`nix run github:janosmiko/lfk`. Update it to the current go modules hash.

Fixes #341
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Walkthrough

The PR updates the vendorHash value in the flake.nix buildGoModule derivation to fix a hash mismatch error. The hash was stale relative to the actual Go module dependencies in version 0.13.3, preventing nix run from succeeding. The change updates the specified hash to match the computed hash of the current Go module vendoring.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description covers the summary and test plan but is missing the Type of change, Changes section with key details, and Testing checklist items required by the template. Add Type of change (mark 'chore:' as this is a maintenance/build configuration update), expand the Changes section with bullet points, and check appropriate Testing boxes or explain why they don't apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the vendorHash in flake.nix for Go modules, which is concise and directly related to the changeset.
Linked Issues check ✅ Passed The PR directly addresses the objective in issue #341 by updating the vendorHash to match the reported 'got' value, fixing the hash mismatch that prevented nix run github:janosmiko/lfk from working.
Out of Scope Changes check ✅ Passed The change is narrowly focused on updating a single fixed-output hash parameter in flake.nix, directly addressing the linked issue requirement with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@janosmiko janosmiko enabled auto-merge (squash) June 2, 2026 03:14
@janosmiko janosmiko merged commit 73c264e into main Jun 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: nix run hash mismatch

1 participant