Request throwing error when status code is 500

[matheussss1]

Package version

9.1.0

Describe the bug

@thetutlage

Why does the client throws an error when the request return a 500 status code?

It makes no sense to me, including the fact that at the docs we have this:

if (response.hasFatalError()) {
  response.error()
}

How could i access reponse.hasFatalError if when the fatal error occurs the client just throw an error and the test stop?

Even if i make a .catch block, the returned value has a prototype of Error, not ApiResponse

Reproduction repo

No response

[andrejfidelleanix]

Throwing for 500+ errors is weird. They can be valid responses returned intentionally (a handled and/or expected error you don't want to report to the user).

Also, not having the ApiResponse object to assert with is worse DX, in my opinion. If you want to ensure the request isn't 500, you can just assert so on the ApiResponse. If you want to assert something about the response (for example: "Server is down for maintenance" vs. "Server is temporarily overloaded" for 503), it's easier to assert bodyContains.

[thetutlage]

We have received quite a few requests for this, so I think many people find throwing exceptions a bit weird. Should we handle 500 exceptions the same way as we handle other exceptions? @RomainLanz @Julien-R44 What you guys think?

[Julien-R44]

Yup, i agree. would be better to be able to make assertions instead of wrapping the test with a try/catch or whatever

[thetutlage]

Okay, let's do it then. It will be a breaking change.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.