Use specifiers to indicate dependence on ordereddict for python2.6 only#23
Merged
jaraco merged 1 commit intojaraco:masterfrom Jan 25, 2019
asottile:patch-1
Merged
Use specifiers to indicate dependence on ordereddict for python2.6 only#23jaraco merged 1 commit intojaraco:masterfrom asottile:patch-1
jaraco merged 1 commit intojaraco:masterfrom
asottile:patch-1
Conversation
Without this, a wheel built in python2 will have incorrect dependencies: - A wheel built with python2.7 will produce a py2-none-any wheel which is a proper installation candidate for a python2.6 pip, but this wheel will not have the ordereddict dependency - A wheel built with python2.6 will produce a py2-none-any wheel which is a proper installation candidate for python2.7 pip, but will unnecessarily install ordereddict. To read more about these markers: - https://www.python.org/dev/peps/pep-0426/#environment-markers For the version specifiers to be honored: - Install from a wheel (requires pip>1.4 (Released in 2013 (ancient)) - Install from a sdist (requires pip>=6 (Released December 2014))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, a wheel built in python2 will have incorrect dependencies: - A wheel built with python2.7 will produce a py2-none-any wheel which is a proper installation candidate for a python2.6 pip, but this wheel will not have the ordereddict dependency - A wheel built with python2.6 will produce a py2-none-any wheel which is a proper installation candidate for python2.7 pip, but will unnecessarily install ordereddict.
To read more about these markers: - https://www.python.org/dev/peps/pep-0426/#environment-markers
For the version specifiers to be honored: - Install from a wheel (requires pip>1.4 (Released in 2013 (ancient)) - Install from a sdist (requires pip>=6 (Released December 2014))