Force using importlib_resources in Python < 3.9#10
Merged
Conversation
Contributor
Author
|
Scratch that part about testing. You're not testing 3.7 or 3.8 that are affected by this. |
Force using the external importlib_resources package based on Python version rather than the presence of the built-in importlib.resources. The latter does not have the needed files() method in Python < 3.9, and therefore results in test failures: E AttributeError: module 'importlib.resources' has no attribute 'files' This affects specifically Python 3.7 and 3.8 that have an older version of importlib.resources module.
mgorny
force-pushed
the
importlib-resources
branch
from
43df3d1 to
7a5274c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force using the external importlib_resources package based on Python
version rather than the presence of the built-in importlib.resources.
The latter does not have the needed files() method in Python < 3.9,
and therefore results in test failures:
E AttributeError: module 'importlib.resources' has no attribute 'files'