Skip to content

Commit 54058ba

Browse files
committed
fix(core): resolve ts compile issues due to lenient tsconfig (angular#29843)
The code failed presubmit in google3 because the original ts config was not as strict as the one used elsewhere in angular/angular and google3. PR Close angular#29843
1 parent 91c7b45 commit 54058ba

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/core/schematics/tsconfig.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
{
22
"compilerOptions": {
3-
"strictNullChecks": true,
43
"noImplicitReturns": true,
4+
"noImplicitAny": true,
5+
"noFallthroughCasesInSwitch": true,
6+
"strictNullChecks": true,
7+
"strictPropertyInitialization": true,
58
"lib": ["es2015"],
69
"types": [],
710
"baseUrl": ".",

packages/core/schematics/utils/typescript/visit_nodes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import * as ts from 'typescript';
1010

11-
export interface TypeScriptVisitor { visitNode(node: ts.Node); }
11+
export interface TypeScriptVisitor { visitNode(node: ts.Node): void; }
1212

1313
export function visitAllNodes(node: ts.Node, visitors: TypeScriptVisitor[]) {
1414
visitors.forEach(v => v.visitNode(node));

0 commit comments

Comments
 (0)