Skip to content

Conversation

jasonyuezhang
Copy link
Owner

Removes the deprecated router props and their corresponding types from the issues list. They were mostly already unused.

part of https://github.com/getsentry/frontend-tsc/issues/93\n\n---\n*Copied from getsentry#100903*\nOriginal PR: getsentry#100903

Removes the deprecated router props and their corresponding types from the issues list. They were mostly already unused.
Copy link

Remove Deprecated Router Props from Issue List

This pull request removes the deprecated router props and associated types (RouteComponentProps, related fixtures, utility imports) from the issue list and its test suites. As part of cleaning up deprecated route handling, component and test files now consume routing and location information using modern hooks and direct context where needed, rather than via props. Several test helpers and usage patterns have been refactored to remove routerProps passing and to use default organization/project fixtures directly.

Key Changes

• Removed usage of router props and RouteComponentProps types from IssueListOverview and related components.
• Refactored tests in static/app/views/issueList/overview.spec.tsx, overview.actions.spec.tsx, and overview.polling.spec.tsx to eliminate routerProps and related object construction.
• Updated static/app/views/issueList/overviewWrapper.tsx and taxonomy-based issue list pages (errorsOutages.tsx, breachedMetrics.tsx, warnings.tsx) to no longer require deprecated route props or type annotations.
• Updated static/app/routes.tsx to remove all deprecatedRouteProps from issue list routes and child taxonomy routes.
• Refactored code to utilize direct hooks (e.g. useLocation) and props from context instead of legacy React Router v3-style props.

Affected Areas

static/app/views/issueList/overview.tsx
static/app/views/issueList/overview.spec.tsx
static/app/views/issueList/overview.actions.spec.tsx
static/app/views/issueList/overview.polling.spec.tsx
static/app/views/issueList/overviewWrapper.tsx
static/app/routes.tsx
static/app/views/issueList/pages/errorsOutages.tsx
static/app/views/issueList/pages/breachedMetrics.tsx
static/app/views/issueList/pages/warnings.tsx

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants