Skip to content

feat(issues): Remove router props from issue list #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(issues): Remove router props from issue list #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions static/app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2556,39 +2556,32 @@ function buildRoutes(): RouteObject[] {
{
index: true,
component: errorHandler(OverviewWrapper),
deprecatedRouteProps: true,
},
{
path: `${IssueTaxonomy.ERRORS_AND_OUTAGES}/`,
component: make(() => import('sentry/views/issueList/pages/errorsOutages')),
deprecatedRouteProps: true,
},
{
path: `${IssueTaxonomy.BREACHED_METRICS}/`,
component: make(() => import('sentry/views/issueList/pages/breachedMetrics')),
deprecatedRouteProps: true,
},
{
path: `${IssueTaxonomy.WARNINGS}/`,
component: make(() => import('sentry/views/issueList/pages/warnings')),
deprecatedRouteProps: true,
},
{
path: 'views/',
component: make(
() => import('sentry/views/issueList/issueViews/issueViewsList/issueViewsList')
),
deprecatedRouteProps: true,
},
{
path: 'views/:viewId/',
component: errorHandler(OverviewWrapper),
deprecatedRouteProps: true,
},
{
path: 'searches/:searchId/',
component: errorHandler(OverviewWrapper),
deprecatedRouteProps: true,
},
// Redirects for legacy tags route.
{
Expand Down
17 changes: 7 additions & 10 deletions static/app/views/issueList/overview.actions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {Fragment} from 'react';
import {GroupFixture} from 'sentry-fixture/group';
import {GroupStatsFixture} from 'sentry-fixture/groupStats';
import {OrganizationFixture} from 'sentry-fixture/organization';
import {RouteComponentPropsFixture} from 'sentry-fixture/routeComponentPropsFixture';

import {
render,
Expand Down Expand Up @@ -84,8 +83,6 @@ describe('IssueListOverview (actions)', () => {
TagStore.init?.();
});

const defaultProps = RouteComponentPropsFixture();

describe('status', () => {
const group1 = GroupFixture({
id: '1',
Expand Down Expand Up @@ -123,7 +120,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {organization});
render(<IssueListOverview />, {organization});

const groups = await screen.findAllByTestId('group');

Expand Down Expand Up @@ -161,7 +158,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {
render(<IssueListOverview />, {
organization,

initialRouterConfig: {
Expand Down Expand Up @@ -223,7 +220,7 @@ describe('IssueListOverview (actions)', () => {

render(
<Fragment>
<IssueListOverview {...defaultProps} />
<IssueListOverview />
<Indicators />
</Fragment>,
{organization}
Expand Down Expand Up @@ -311,7 +308,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {
render(<IssueListOverview />, {
organization,

initialRouterConfig: {
Expand Down Expand Up @@ -387,7 +384,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {
render(<IssueListOverview />, {
organization,
});

Expand Down Expand Up @@ -430,7 +427,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {
render(<IssueListOverview />, {
organization,

initialRouterConfig: {
Expand Down Expand Up @@ -473,7 +470,7 @@ describe('IssueListOverview (actions)', () => {
method: 'PUT',
});

render(<IssueListOverview {...defaultProps} />, {
render(<IssueListOverview />, {
organization,

initialRouterConfig: {
Expand Down
20 changes: 3 additions & 17 deletions static/app/views/issueList/overview.polling.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import {GroupFixture} from 'sentry-fixture/group';
import {GroupStatsFixture} from 'sentry-fixture/groupStats';
import {LocationFixture} from 'sentry-fixture/locationFixture';
import {MemberFixture} from 'sentry-fixture/member';
import {ProjectFixture} from 'sentry-fixture/project';
import {TagsFixture} from 'sentry-fixture/tags';

import {initializeOrg} from 'sentry-test/initializeOrg';
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
import {textWithMarkupMatcher} from 'sentry-test/utils';

Expand Down Expand Up @@ -38,26 +37,13 @@ describe('IssueList -> Polling', () => {
MockApiClient.clearMockResponses();
});

const {organization, project, routerProps} = initializeOrg({
organization: {
access: ['project:releases'],
},
});
const project = ProjectFixture();
const group = GroupFixture({project});
const group2 = GroupFixture({project, id: '2'});

const defaultProps = {
location: LocationFixture({
query: {query: 'is:unresolved'},
search: 'query=is:unresolved',
}),
params: {},
organization,
};

/* helpers */
const renderComponent = async () => {
render(<IssueList {...routerProps} {...defaultProps} />, {
render(<IssueList />, {
initialRouterConfig: {
location: {
pathname: '/organizations/org-slug/issues/',
Expand Down
Loading