PAYARA-1943 JSON-P Examples #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
reviewed
Sep 19, 2017
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.json</groupId> |
There was a problem hiding this comment.
This one should have been defined at the top level and then replaced by the Java EE 8 dependency when that became available (which just happened ;))
arjantijms
reviewed
Sep 19, 2017
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.glassfish</groupId> |
There was a problem hiding this comment.
Server specific things should be added to the profile for that server
|
Nice tests! Lots of Wibbly there :P |
Pandrex247
pushed a commit
to Pandrex247/javaee8-samples
that referenced
this pull request
Mar 21, 2019
…tests QA-125 exluding test until resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples / tests for JSON-P Patches, Merges, and Pointers.