Skip to content

Always build sources #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

Always build sources #236

merged 1 commit into from
Jul 26, 2022

Conversation

@kerner1000
Copy link
Contributor

@kerner1000 kerner1000 commented Jul 23, 2022

No description provided.

@fvarrui
Copy link
Collaborator

fvarrui commented Jul 26, 2022

I'm not really sure about this change ... please, can you explain me what it does? 😅
Thanks!

@kerner1000
Copy link
Contributor Author

kerner1000 commented Jul 26, 2022

Hi @fvarrui ,
I usually don't use Gradle, so this is maybe not how it's supposed to be but for me this change did was I was excepting 🙈.
The Idea of this PR is to include the generation of a sources jar also in non-release builds.
That is important when you are developing on the plugin so your IDE can attach the current sources and you can debug out of the other project that you are developing and which is using this Maven/ Gradle plugin.

@fvarrui fvarrui merged commit d517ec0 into javapackager:devel Jul 26, 2022
@fvarrui
Copy link
Collaborator

fvarrui commented Jul 26, 2022 •
edited
Loading

Great! You convinced me 😄 ... It makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerner1000 @fvarrui