Skip to content

improvement: Improve the error message when downloading the AppImageTool fails #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

improvement: Improve the error message when downloading the AppImageTool fails #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/main/java/io/github/fvarrui/javapackager/packagers/GenerateAppImage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
package io.github.fvarrui.javapackager.packagers;

import java.io.File;
import java.io.IOException;

import org.apache.commons.lang3.SystemUtils;

import io.github.fvarrui.javapackager.model.Platform;
import io.github.fvarrui.javapackager.utils.CommandUtils;
import io.github.fvarrui.javapackager.utils.FileUtils;
import io.github.fvarrui.javapackager.utils.Logger;
import io.github.fvarrui.javapackager.utils.VelocityUtils;
import org.apache.commons.lang3.SystemUtils;

import java.io.File;
import java.io.IOException;

public class GenerateAppImage extends ArtifactGenerator<LinuxPackager> {

Expand Down Expand Up @@ -97,7 +96,7 @@ private File getAppImageTool(LinuxPackager packager) throws Exception {
try {
FileUtils.downloadFromUrl(imageToolUrl, appImageTool);
} catch (IOException e) {
throw new Exception(imageToolUrl + "not found! ... Unsupported OS architecture " + getOSArch() + "?");
throw new Exception("An error occurred while downloading appimagetool from " + imageToolUrl + " for " + getOSArch() + "! It may be a network problem or the url " + imageToolUrl + " is not valid!", e);
}
appImageTool.setExecutable(true);
}
Expand Down