Skip to content

Conversation

jlerbsc
Copy link
Collaborator

@jlerbsc jlerbsc commented Dec 5, 2022

… if some nodes are identical

Fixes #3773 .

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #3776 (d5b3d9f) into master (47db375) will increase coverage by 0.027%.
The diff coverage is 100.000%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master     #3776       +/-   ##
===============================================
+ Coverage     57.358%   57.385%   +0.027%     
  Complexity      2520      2520               
===============================================
  Files            635       635               
  Lines          33751     33763       +12     
  Branches        5838      5838               
===============================================
+ Hits           19359     19375       +16     
+ Misses         12313     12309        -4     
  Partials        2079      2079               
Flag Coverage Δ
AlsoSlowTests 57.385% <100.000%> (+0.027%) ⬆️
javaparser-core 51.957% <100.000%> (+0.061%) ⬆️
javaparser-symbol-solver 36.554% <0.000%> (-0.013%) ⬇️
jdk-10 57.378% <100.000%> (+0.024%) ⬆️
jdk-11 57.375% <100.000%> (+0.027%) ⬆️
jdk-12 57.381% <100.000%> (+0.032%) ⬆️
jdk-13 57.381% <100.000%> (+0.027%) ⬆️
jdk-14 57.381% <100.000%> (+0.032%) ⬆️
jdk-15 57.381% <100.000%> (+0.027%) ⬆️
jdk-16 57.381% <100.000%> (+0.027%) ⬆️
jdk-8 57.382% <100.000%> (+0.027%) ⬆️
jdk-9 57.381% <100.000%> (+0.027%) ⬆️
macos-latest 57.373% <100.000%> (+0.027%) ⬆️
ubuntu-latest 57.370% <100.000%> (+0.026%) ⬆️
windows-latest 57.364% <100.000%> (+0.027%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xicalpreservation/DifferenceElementCalculator.java 86.746% <100.000%> (+1.032%) ⬆️
...m/github/javaparser/ast/visitor/EqualsVisitor.java 28.260% <0.000%> (+0.217%) ⬆️
...in/java/com/github/javaparser/ast/stmt/IfStmt.java 55.405% <0.000%> (+2.702%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47db375...d5b3d9f. Read the comment docs.

@jlerbsc
Copy link
Collaborator Author

jlerbsc commented Dec 5, 2022

As usual compilation on java 10 ubuntu fails due to bug in compiler.

@jlerbsc jlerbsc merged commit 28bd049 into javaparser:master Dec 5, 2022
@jlerbsc jlerbsc added this to the next release milestone Dec 5, 2022
@jlerbsc jlerbsc added the PR: Fixed A PR that offers a fix or correction label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Fixed A PR that offers a fix or correction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacing nodes causes error in lexical preserving printer if some nodes are identical

1 participant